Skip to content

TST/DEPR: fix bunch of Panel deprecation warnings #15965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 11, 2017
Merged

TST/DEPR: fix bunch of Panel deprecation warnings #15965

merged 10 commits into from
Apr 11, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 10, 2017

No description provided.

@jreback jreback added Deprecate Functionality to remove in pandas Testing pandas testing functions or related to the test suite labels Apr 10, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 10, 2017
@codecov
Copy link

codecov bot commented Apr 10, 2017 •
edited
Loading

Codecov Report

Merging #15965 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15965   +/-   ##
=======================================
  Coverage      91%      91%           
=======================================
  Files         145      145           
  Lines       49581    49581           
=======================================
  Hits        45122    45122           
  Misses       4459     4459
Flag Coverage Δ
#multiple 88.77% <100%> (ø) ⬆️
#single 40.57% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/types/missing.py 87.89% <100%> (ø) ⬆️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/tseries/index.py 95.33% <0%> (-0.1%) ⬇️
pandas/util/testing.py 81.13% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838e09c...bbe32e1. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 10, 2017 •
edited
Loading

Codecov Report

Merging #15965 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15965      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         145      145              
  Lines       49581    49581              
==========================================
+ Hits        45122    45124       +2     
+ Misses       4459     4457       -2
Flag Coverage Δ
#multiple 88.77% <100%> (ø) ⬆️
#single 40.57% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/types/missing.py 87.89% <100%> (ø) ⬆️
pandas/util/testing.py 81.13% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838e09c...71ffff5. Read the comment docs.

jorisvandenbossche
jorisvandenbossche approved these changes Apr 10, 2017
View reviewed changes
pandas/tests/test_sorting.py Outdated
self.assertEqual(len(left), len(right))
assert left[k] == right[k[::-1]]
assert left[k] == v
len(left) == len(right)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing assert ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated. was having some other issues :>

@jreback jreback merged commit fbbcc10 into pandas-dev:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @jorisvandenbossche